Browse Source

storage-node-v2: Update code comments.

Shamil Gadelshin 3 years ago
parent
commit
ee1c0b2128

+ 0 - 1
storage-node-v2/src/commands/dev/init.ts

@@ -1,7 +1,6 @@
 import { hireStorageWorkingGroupLead } from '../../services/runtime/hireLead'
 import ApiCommandBase from '../../command-base/ApiCommandBase'
 
-// TODO: consider renaming the command - DevHireLeader
 export default class DevInit extends ApiCommandBase {
   static description =
     'Initialize development environment. Sets Alice as storage working group leader.'

+ 2 - 2
storage-node-v2/src/commands/operator/accept-invitation.ts

@@ -9,7 +9,7 @@ export default class OperatorAcceptInvitation extends ApiCommandBase {
   static flags = {
     worker: flags.integer({
       char: 'w',
-      required: true, // TODO: for dev
+      required: true,
       description: 'Storage operator worker ID',
     }),
     bucket: flags.integer({
@@ -23,7 +23,7 @@ export default class OperatorAcceptInvitation extends ApiCommandBase {
   async run(): Promise<void> {
     const { flags } = this.parse(OperatorAcceptInvitation)
 
-    const worker = flags.worker ?? 0 // TODO: don't require on dev???
+    const worker = flags.worker ?? 0
     const bucket = flags.bucket ?? 0
 
     logger.info('Accepting pending storage bucket invitation...')

+ 2 - 5
storage-node-v2/src/commands/server.ts

@@ -3,16 +3,13 @@ import { createApp } from '../services/webApi/app'
 import ApiCommandBase from '../command-base/ApiCommandBase'
 import logger from '../services/logger'
 
-// TODO: fix command not found error (error handling)
-// TODO: custom IP address?
-
 export default class Server extends ApiCommandBase {
   static description = 'Starts the storage node server.'
 
   static flags = {
     worker: flags.integer({
       char: 'w',
-      required: true, // TODO: for dev
+      required: true,
       description: 'Storage provider worker ID',
     }),
     uploads: flags.string({
@@ -42,7 +39,7 @@ export default class Server extends ApiCommandBase {
 
     try {
       const port = flags.port
-      const workerId = flags.worker ?? 0 // TODO: don't require on dev???
+      const workerId = flags.worker ?? 0
       const app = await createApp(api, account, workerId, flags.uploads)
       logger.info(`Listening on http://localhost:${port}`)
       app.listen(port)

+ 0 - 1
storage-node-v2/src/services/runtime/api.ts

@@ -76,7 +76,6 @@ function sendExtrinsic(
                   resolve(result)
                 } else {
                   reject(
-                    // TODO: print error
                     new ExtrinsicFailedError(
                       'Sudo extrinsic execution error!',
                       {

+ 0 - 3
storage-node-v2/src/services/webApi/app.ts

@@ -12,9 +12,6 @@ import { ApiPromise } from '@polkadot/api'
 import { TokenRequest, verifyTokenSignature } from '../helpers/auth'
 import { httpLogger } from '../../services/logger'
 
-// TODO: custom errors (including validation errors)
-// TODO: custom authorization errors
-
 // Creates web API application.
 export async function createApp(
   api: ApiPromise,