Переглянути джерело

make build_images job of network tests run even without label

Mokhtar Naamani 4 роки тому
батько
коміт
bb6571206d

+ 9 - 7
.github/workflows/joystream-node-checks.yml

@@ -4,7 +4,7 @@ on:
 
 jobs:
   checks:
-    name: joystream-node native build and checks
+    name: joystream-node checks
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v1
@@ -27,9 +27,11 @@ jobs:
       # - name: Check version modified correctly
       #   if: env.GIT_DIFF
 
-      - name: Build if runtime was modified
-        run: |
-          ./setup.sh
-          yarn cargo-checks
-          yarn cargo-build
-        if: env.GIT_DIFF
+      # This Building natively is not really necessary because we have the docker build which
+      # hapens in the run-network-tests workflow which is sufficient!
+      # - name: Build if runtime was modified
+      #   run: |
+      #     ./setup.sh
+      #     yarn cargo-checks
+      #     yarn cargo-build
+      #   if: env.GIT_DIFF

+ 11 - 2
.github/workflows/run-network-tests.yml

@@ -1,12 +1,21 @@
 name: run-network-tests
 on:
   pull_request:
-    types: [labeled, synchronize]
   workflow_dispatch:
+    # TODO: add an input so dispatcher can specify a list of tests to run,
+    # composed of the job ids separated by `:`
+    # for eg.
+    #   'network_tests_1:network_tests_3'
+    #   'network_tests_2'
+    # inputs:
+    #   test_to_run:
+    #     description: 'Tests to run'
+    #     required: false
+    #     default: 'all'
 
 jobs:
   build_images:
-    name: Prepare joystream/node docker image
+    name: Build joystream/node
     runs-on: ubuntu-latest
     outputs:
       use_artifact: ${{ steps.compute_shasum.outputs.shasum }}-joystream-node-docker-image.tar.gz

+ 1 - 0
tests/network-tests/run-tests.sh

@@ -49,4 +49,5 @@ docker run -v ${DATA_PATH}:/data -d -p 9944:9944 joystream/node \
   --validator --alice --unsafe-ws-external --rpc-cors=all --log runtime \
   --chain /data/chain-spec-raw.json
 
+# Execute the tests
 yarn workspace network-tests test